Increase note graph max zoom and harden zoom/label tests#825
Merged
multiplex55 merged 1 commit intomasterfrom Feb 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
zoom_aboutbehavior continues to anchor to the pointer even when zoom values are clamped at the new bounds.Description
MAX_ZOOMfrom2.5to4.0insrc/gui/note_graph_dialog.rs.label_zoom_thresholdclamping inapply_settingsto useMAX_ZOOMinstead of the previous hard-coded upper bound.DragValueforlabel_zoom_thresholdto.clamp_range(0.2..=MAX_ZOOM)to expose the expanded range to users.src/gui/note_graph_dialog.rsto verify zoom clamping to the new upper bound, thatzoom_aboutpreserves the pointer anchor when clamped near both min and max, and thatlabel_zoom_thresholdclamps toMAX_ZOOM.Testing
src/gui/note_graph_dialog.rscovering the new zoom and label behaviors; the tests compile in supported environments.cargo test src::gui::note_graph_dialog -- --nocapture, but the run failed in this environment due to the installedrustcbeing1.87.0while a dependency (time 0.3.47) requiresrustc 1.88.0, so tests could not be executed here.Codex Task